🦋 Changeset detected

Latest commit: 833fc86

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
hyperdx-v2-oss-app	Ready	Preview	Comment	Nov 6, 2025 11:55pm

PR Review: Webhook UX Improvements

✅ Overall: Well-implemented feature with good test coverage. A few issues to address:

Critical Issues

• ⚠️ Missing error handling in test endpoint (webhooks.ts:251-254) → Webhook test errors are not caught - network failures or invalid URLs will cause unhandled promise rejections that may crash the server. Wrap the webhook send calls in try-catch.

• ❌ Unsaved webhook test object (webhooks.ts:234-241) → Creating new Webhook() without .save() for test may cause issues if webhook handlers expect saved documents with IDs or timestamps. Use plain object instead of Mongoose instance.

Code Quality Issues

• 🔍 Inconsistent typing (api.ts:332-395) → Return types use any in mutation definitions. Should use proper types from types.ts (e.g., { data: Webhook }).

• ⚠️ Service type validation (webhooks.ts:254-257) → The else block for unsupported service type is unreachable due to Zod validation. Remove dead code or add comment explaining it is defensive.

Suggestions

• Consider adding rate limiting to the test endpoint to prevent abuse
• The webhook form disables service type during edit (WebhookForm.tsx:256, 261) - document why in a comment if intentional

Action: Address the error handling and Mongoose instance issues before merging.

E2E Test Results

✅ All tests passed • 39 passed • 3 skipped • 304s

View full report →

Tested locally and things look great! Sorry there's a conflict due to my slowness :( @brandon-pereira